dd: move dd_out() function up to module level #4428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
dd_out()
function out of theimpl Output
and up to themodule level, renaming it to
dd_copy()
. This change aligns it withthe pattern set by
std::io::copy()
, which similarly takes an inputreader and an output writer.
This does not change the behavior of
dd
, just the code organizationto make it more closely match the idioms in the Rust standard library.